Support #9832
openWorked on POS module and orders add items flow
100%
Description
1. Customer Email Validation (POS)
Fixed — the field was accepting junk emails like "asdd@ddddd.cdddd" since the regex only checked for "something@something.something". Now validates proper domain structure with a real TLD + length limits. Also added server-side validation, since the API had none before (bad emails could be saved by bypassing the UI).
2. Guest Count Limit (Dine-In)
Fixed — "Number of Guests" accepted unlimited values. Now capped at the selected table's capacity (including merged tables), and blocks the order if it exceeds. Earlier, staff only found out via a server error after building the whole cart.
3. Add Items Dialog Crash
Fixed — clicking an item or category made the dialog disappear and show the order details screen underneath. Caused by a React hook being called after an early return. Also fixed menu loading to happen on open, not on mount.
4. Duplicate Items on Orders
Fixed — adding the same dish twice created separate lines (e.g. Aloo Damka ×3 as 3 rows) instead of merging quantity. Now identical lines merge correctly, while different spice levels/options stay separate. Items the kitchen has already started are never altered.
5. Spice Levels & Required Options Missing
Fixed — the Add Items dialog was ignoring spice levels and modifier groups entirely, and modifiers weren't even being sent to the server. Variant pricing now matches POS.
6. Add Items Flow Rebuilt
The old dialog is removed. "Add Items" now opens the POS page with the order's customer, table, and items prefilled, saving back to the same order. Existing items are display-only; only new additions are editable. Also fixed a data-loss bug where editing an order silently stripped modifiers, spice levels, and notes from existing items.
7. Tax Not Recalculating
Fixed — updating an order used a hardcoded 5% GST instead of the real tax engine, and never saved the recalculated tax/subtotal — causing the bill to disagree with its own line items. Now recalculates correctly on quantity/item changes
8. Deployed Code in Test Environment
Subtasks
Related issues