Project

General

Profile

Edit Copy Actions

Feature #10867

closed

check and move main branch landscaping changes to subscription branch

Added by Chandra Sekhar about 2 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Target version:
-
Start date:
09/15/2026
Due date:
09/21/2026
% Done:

100%

Estimated time:
Spent time:

Add

Subtasks


Add

Related issues

Actions #1

Updated by Chandra Sekhar about 2 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Chandra Sekhar about 2 months ago

  • Due date changed from 09/15/2026 to 09/16/2026
  • % Done changed from 0 to 60
Actions #3

Updated by Chandra Sekhar about 2 months ago

  • Subject changed from check and move main branch changes to subscription branch to check and move main branch landscaping changes to subscription branch
  • Due date changed from 09/16/2026 to 09/17/2026
  • % Done changed from 60 to 80
Actions #4

Updated by Chandra Sekhar about 2 months ago

  • Due date changed from 09/17/2026 to 09/18/2026
  • % Done changed from 80 to 90
Actions #5

Updated by Chandra Sekhar about 1 month ago

  • Due date changed from 09/18/2026 to 09/21/2026

Updated by Chandra Sekhar about 1 month ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

1. πŸ“¬ Requests Module
Optimized Dashboard Stats (Removed Redundant API Call):
Previous: The Requests page fired two separate requests on load: GET /request?... (for list) and GET /request/requestcount (for top dashboard stat cards).
Today’s Update: Updated Request.tsx to read dashboards counts (totalCount, dailyRequestsCount, weeklyRequestsCount, monthlyRequestsCount) directly from the primary GET /request response. Removed the extra /request/requestcount API call.
Benefit: Reduces initial page load network requests and prevents race conditions in stats rendering.
Deleted Requests Server-Side Date Filtering:
Moved date filtering from in-memory frontend array operations to indexed database query parameters (from & to sent to GET /request/get-Deleted-Requests).
Deletion Reason / Comments Persistence:
Fixed delete modal payload to ensure entered deletion comments are persisted into request.comments, audit actionHistory, and event notifications.
2. πŸ› οΈ Jobs Module
Server-Side Date Filtering on Deleted Jobs:
Replaced client-side memory filtering in Jobs.tsx with server-side from/to parameters passed to GET /job/get-deleted-jobs.
Added Status Column in Deleted Jobs Table:
Added sortable Status column to tableHeaders1 with color-coded status chips (New, InProgress, Auto, Completed, Cancelled) matching active jobs.
Subscription Job Indicator:
Added green "Subscription Job" badge above the Serial Number / Job ID in both active and deleted jobs tables whenever subscriptionMeta.enabled is true.
3. πŸ“‘ Quotations & Financial Calculations Audit
Reduced API Overhead:
Minimized duplicate quote fetch calls on quotes landing page, improving initial render response time.
Comprehensive Audit of Discount & Tax Permutations:
Audited and verified all 4 financial calculation combinations across EditQuotations.tsx, CreateQuoteWithoutRequestFlow.tsx, and InvoicePage.tsx:
Without Discount & Without Tax: Total = Subtotal, Tax = $0.
Without Discount & With Tax: Total = Subtotal + Tax.
With Discount & Without Tax: Total = (Subtotal βˆ’ Discount), Tax = $0.
With Discount & With Tax: Total = (Subtotal βˆ’ Discount) + Tax (Tax correctly calculated on post-discount subtotal).
4. πŸ”„ Cross-Branch Compatibility Audit (main vs subscription)
Audited editing behavior when opening Main Branch records inside Subscriptions:
Requests: Customer data, selected services, products, equipment, labor, and site visits map 100% accurately.
Quotes: QuoteEditFlowPage auto-detects request-based vs direct quotes and routes to the correct editor with exact line items, tax, and discount prefill.
Jobs: Schedule, team assignments, attached quotation, and service addresses load with full backward compatibility.

Edit Copy Actions

Also available in: Atom PDF