Evergreen farms (pos)

Reviewed the code from 08/14/2026 to 08/17/2026 and got below issues
Findings
Severity Area Issue and impact
High Vendor invoices A soft-deleted draft invoice can still be modified through existing ID-based payment/status APIs because they use findById() without isDeleted: { $ne: true }. Deleted invoices can also remain eligible for return adjustments. This can alter balances and financial records that should be inactive. [controller (line 2126)](C:/thriveni/folder f/POS/EGF_POS/main-branch/evergreen_pos_be/src/controllers/vendorInvoiceController.js:2126)
High Subscription inventory Vendor-invoice delete/restore commits stock changes first, then runs subscription-ledger synchronization outside the transaction. That helper catches failures and only logs them, while the API still returns success. Subscription-controlled inventory can therefore have correct physical stock but stale reservation/ledger state, risking incorrect availability. [sync helper (line 2743)](C:/thriveni/folder f/POS/EGF_POS/main-branch/evergreen_pos_be/src/controllers/vendorInvoiceController.js:2743)
Medium Subscription emails Both new payment-confirmation templates hard-code “Service Tax (7%)” and derive tax by dividing by 1.07, rather than using the actual contract/company charge. Customers can receive incorrect tax, subtotal, and yearly-total breakdowns where the rate is not exactly 7%. [on-store template (line 114)](C:/thriveni/folder f/POS/EGF_POS/main-branch/evergreen_pos_be/src/views/emails/subscriptionPayemtRecievedOnStore.ejs:114), [off-store template (line 114)](C:/thriveni/folder f/POS/EGF_POS/main-branch/evergreen_pos_be/src/views/emails/subscriptionPayemtRecievedOffStore.ejs:114)
Medium POS scale connectivity The frontend marks the socket scale agent as reachable when agentConnected is true, but does not clear that state when the backend emits agentConnected: false. If the local agent is also unavailable, the “desktop service missing” warning can remain hidden after the remote agent disconnects. [CartComponent (line 1273)](C:/thriveni/folder f/POS/EGF_POS/main-branch/evergreen_pos_fe/src/pages/Nuresy/POS/CartComponent.tsx:1273)
assign to divya and teja